1
0
قرینه از https://github.com/matomo-org/matomo.git synced 2025-08-21 22:47:43 +00:00
Files
matomo/plugins/SegmentEditor/SegmentSelectorControl.php
Stefan Giehl 5843d8d682 Ensure a user can still change their segment after it was shared by super user (#23041)
* Ensure a user can still change their segment if a super user updated it to be share with other users

* Add regression tests

* Adds typehints to SegmentEditor API

* Disable auto sanitize for SegmentEditor API

* fixes around type hints

* unsanitize segment name

* use request class instead of common::getRequestVar

* Disallow changing enabledAllUsers for normal users during segment update

* Throw a proper exception when trying to edit a segment with enable_only_idsite=0

* make some errors translatable

* ensure removing all sites segments is only allowed for super user

* Update plugins/SegmentEditor/tests/Integration/SegmentEditorTest.php

---------

Co-authored-by: Marc Neudert <marc@innocraft.com>
2025-02-20 08:58:08 +01:00

150 خطوط
5.6 KiB
PHP

<?php
/**
* Matomo - free/libre analytics platform
*
* @link https://matomo.org
* @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
*/
namespace Piwik\Plugins\SegmentEditor;
use Piwik\API\Request;
use Piwik\ArchiveProcessor\Rules;
use Piwik\Config;
use Piwik\Container\StaticContainer;
use Piwik\Piwik;
use Piwik\Plugin\Manager;
use Piwik\Plugins\API\API as APIMetadata;
use Piwik\Plugins\Live\Live;
use Piwik\Plugins\UsersManager\API as UsersManagerAPI;
use Piwik\View\UIControl;
use Piwik\Plugins\SegmentEditor\API as SegmentEditorAPI;
/**
* Generates the HTML for the segment selector control (which includes the segment editor).
*/
class SegmentSelectorControl extends UIControl
{
public const TEMPLATE = "@SegmentEditor/_segmentSelector";
/**
* Constructor.
*/
public function __construct()
{
parent::__construct();
$this->jsClass = "SegmentSelectorControl";
$this->cssIdentifier = "segmentEditorPanel";
$this->cssClass = "piwikTopControl borderedControl piwikSelector";
$idSiteFromRequest = \Piwik\Request::fromRequest()->getIntegerParameter('idSite', -1);
$this->idSite = $idSiteFromRequest !== -1 ? $idSiteFromRequest : null;
$formatter = StaticContainer::get('Piwik\Plugins\SegmentEditor\SegmentFormatter');
$this->segmentDescription = $formatter->getHumanReadable(Request::getRawSegmentFromRequest(), $this->idSite);
$this->isAddingSegmentsForAllWebsitesEnabled = SegmentEditor::isAddingSegmentsForAllWebsitesEnabled();
$this->isCreateRealtimeSegmentsEnabled = SegmentEditor::isCreateRealtimeSegmentsEnabled();
$segments = APIMetadata::getInstance()->getSegmentsMetadata($this->idSite);
$visitTitle = Piwik::translate('General_Visit');
foreach ($segments as $segment) {
if (
$segment['category'] == $visitTitle
&& ($segment['type'] == 'metric' && $segment['segment'] != 'visitIp')
) {
$metricsLabel = mb_strtolower(Piwik::translate('General_Metrics'));
$segment['category'] .= ' (' . $metricsLabel . ')';
}
}
$this->createRealTimeSegmentsIsEnabled = $this->isCreatingRealTimeSegmentsEnabled();
$this->nameOfCurrentSegment = '';
$this->isSegmentNotAppliedBecauseBrowserArchivingIsDisabled = 0;
$this->selectedSegment = \Piwik\Request::fromRequest()->getStringParameter('segment', '');
$this->availableSegments = SegmentEditor::getAllSegmentsForSite($this->idSite);
foreach ($this->availableSegments as &$savedSegment) {
if (!empty($this->selectedSegment) && $this->selectedSegment == $savedSegment['definition']) {
$this->nameOfCurrentSegment = $savedSegment['name'];
$this->isSegmentNotAppliedBecauseBrowserArchivingIsDisabled =
$this->wouldApplySegment($savedSegment) ? 0 : 1;
}
}
$this->authorizedToCreateSegments = SegmentEditorAPI::getInstance()->isUserCanAddNewSegment($this->idSite);
$this->isUserAnonymous = Piwik::isUserIsAnonymous();
$this->segmentTranslations = $this->getTranslations();
$this->segmentProcessedOnRequest = Rules::isBrowserArchivingAvailableForSegments();
$this->hideSegmentDefinitionChangeMessage = UsersManagerAPI::getInstance()->getUserPreference(
'hideSegmentDefinitionChangeMessage',
Piwik::getCurrentUserLogin()
);
$this->isBrowserArchivingEnabled = Rules::isBrowserTriggerEnabled();
$this->isVisitorLogEnabled = Manager::getInstance()->isPluginActivated('Live') && Live::isVisitorLogEnabled($this->idSite);
}
public function getClientSideProperties()
{
return array('availableSegments',
'segmentTranslations',
'isSegmentNotAppliedBecauseBrowserArchivingIsDisabled',
'selectedSegment',
'authorizedToCreateSegments');
}
private function wouldApplySegment($savedSegment)
{
if (Rules::isBrowserArchivingAvailableForSegments()) {
return true;
}
return (bool) $savedSegment['auto_archive'];
}
private function getTranslations()
{
$translationKeys = array(
'General_OperationEquals',
'General_OperationNotEquals',
'General_OperationAtMost',
'General_OperationAtLeast',
'General_OperationLessThan',
'General_OperationGreaterThan',
'General_OperationContains',
'General_OperationDoesNotContain',
'General_OperationStartsWith',
'General_OperationEndsWith',
'General_OperationIs',
'General_OperationIsNot',
'General_OperationContains',
'General_OperationDoesNotContain',
'SegmentEditor_DefaultAllVisits',
'General_DefaultAppended',
'SegmentEditor_AddNewSegment',
'General_Edit',
'General_Search',
'General_SearchNoResults',
);
$translations = array();
foreach ($translationKeys as $key) {
$translations[$key] = Piwik::translate($key);
}
return $translations;
}
protected function isCreatingRealTimeSegmentsEnabled()
{
// when browser archiving is disabled for segments, we force new segments to be created as pre-processed
if (!Rules::isBrowserArchivingAvailableForSegments()) {
return false;
}
return (bool) Config::getInstance()->General['enable_create_realtime_segments'];
}
}