قرینه از
https://github.com/matomo-org/matomo.git
synced 2025-08-25 00:17:37 +00:00
b8cbe71a76
* Added the ability to force the use of an index * Improving test a little more * Make suggested comment correction Co-authored-by: Michal Kleiner <michal@innocraft.com> * Make suggested comment correction Co-authored-by: Michal Kleiner <michal@innocraft.com> * Adding new config to control use of new feature * Fixing test after recent change * Fixing test to avoid affecting other tests * Fixing PHPCS error * Applying some PR review feedback from Cloud team * Fixing edge case * Adding test case around regression found in patch on Cloud * Making slight test case improvement * Removed config for forcing index * Removed unused import * Remove no longer needed code * remove unneeded use statement --------- Co-authored-by: Michal Kleiner <michal@innocraft.com> Co-authored-by: Stefan Giehl <stefan@matomo.org>
99 خطوط
3.9 KiB
PHP
99 خطوط
3.9 KiB
PHP
<?php
|
|
|
|
/**
|
|
* Matomo - free/libre analytics platform
|
|
*
|
|
* @link https://matomo.org
|
|
* @license https://www.gnu.org/licenses/gpl-3.0.html GPL v3 or later
|
|
*/
|
|
|
|
namespace Piwik\Tests\Unit\DataAccess;
|
|
|
|
use Piwik\ArchiveProcessor\Parameters;
|
|
use Piwik\Config\DatabaseConfig;
|
|
use Piwik\DataAccess\ArchivingDbAdapter;
|
|
use Piwik\DataAccess\LogAggregator;
|
|
use Piwik\Date;
|
|
use Piwik\Period\Factory;
|
|
use Piwik\Segment;
|
|
use Piwik\Tests\Framework\Mock\Site;
|
|
|
|
/**
|
|
* @group Core
|
|
*/
|
|
class LogAggregatorTest extends \PHPUnit\Framework\TestCase
|
|
{
|
|
public function testQueryConversionsByDimensionForcingIndexFlagJoinPrefixHint()
|
|
{
|
|
$expectedSql = 'SELECT /*+ JOIN_PREFIX(log_conversion) */ /* segmenthash */ /* sites 1 */ ';
|
|
$dbMock = $this->createMock(ArchivingDbAdapter::class);
|
|
$dbMock->expects($this->once())->method('query')->with($this->stringContains($expectedSql), $this->equalTo([]));
|
|
|
|
DatabaseConfig::setConfigValue('enable_first_table_join_prefix', 1);
|
|
|
|
$segmentMock = $this->createMock(Segment::class);
|
|
$segmentMock->expects($this->once())->method('getSelectQuery')
|
|
->with($this->anything(), $this->equalTo([['table' => 'log_conversion', 'useIndex' => 'index_idsite_datetime']]))
|
|
->willReturn(['sql' => 'SELECT * FROM log_visit', 'bind' => []]);
|
|
|
|
$aggregatorMock = $this->createPartialMock(LogAggregator::class, ['getDb']);
|
|
$aggregatorMock->expects($this->once())->method('getDb')->willReturn($dbMock);
|
|
$aggregatorMock->__construct(new Parameters(new Site(1), Factory::build('day', Date::now()), $segmentMock));
|
|
$aggregatorMock->queryConversionsByDimension([], '', [], [], false, false, true);
|
|
}
|
|
|
|
/**
|
|
* @dataProvider getTestQueryConversionsByDimensionForcingIndexFlagTestData
|
|
*
|
|
* @param bool $forceIndex
|
|
* @return void
|
|
*/
|
|
public function testQueryConversionsByDimensionForcingIndexFlag(bool $forceIndex)
|
|
{
|
|
$dimensions = ['custom_var_k1', 'custom_var_v1'];
|
|
$where = "%s.custom_var_k1 != ''";
|
|
$extraFrom = [
|
|
[
|
|
'table' => 'log_visit',
|
|
'joinOn' => 'log_visit.idvisit = log_conversion.idvisit',
|
|
],
|
|
];
|
|
|
|
$expectedSelect = "log_conversion.idgoal AS `idgoal`,
|
|
log_conversion.custom_var_k1 AS `custom_var_k1`,
|
|
log_conversion.custom_var_v1 AS `custom_var_v1`,
|
|
count(*) AS `1`,
|
|
count(distinct log_conversion.idvisit) AS `3`,
|
|
ROUND(SUM(log_conversion.revenue),2) AS `2`,
|
|
ROUND(SUM(log_conversion.revenue_subtotal),2) AS `4`,
|
|
ROUND(SUM(log_conversion.revenue_tax),2) AS `5`,
|
|
ROUND(SUM(log_conversion.revenue_shipping),2) AS `6`,
|
|
ROUND(SUM(log_conversion.revenue_discount),2) AS `7`,
|
|
SUM(log_conversion.items) AS `8`";
|
|
$expectedFrom = $forceIndex
|
|
? [['table' => LogAggregator::LOG_CONVERSION_TABLE, 'useIndex' => 'index_idsite_datetime']]
|
|
: [LogAggregator::LOG_CONVERSION_TABLE];
|
|
$expectedFrom = array_merge($expectedFrom, $extraFrom);
|
|
$expectedWhere = "log_conversion.server_time >= ?
|
|
AND log_conversion.server_time <= ?
|
|
AND log_conversion.idsite IN (?) AND log_conversion.custom_var_k1 != ''";
|
|
|
|
$dbMock = $this->createMock(ArchivingDbAdapter::class);
|
|
$dbMock->expects($this->once())->method('query');
|
|
|
|
$aggregatorMock = $this->createPartialMock(LogAggregator::class, ['generateQuery', 'getDb']);
|
|
$aggregatorMock->expects($this->once())->method('generateQuery')->with($expectedSelect, $expectedFrom, $expectedWhere)->willReturn(['sql' => '', 'bind' => []]);
|
|
$aggregatorMock->expects($this->once())->method('getDb')->willReturn($dbMock);
|
|
$aggregatorMock->setSites([1]);
|
|
$aggregatorMock->queryConversionsByDimension($dimensions, $where, [], $extraFrom, false, false, $forceIndex);
|
|
}
|
|
|
|
public function getTestQueryConversionsByDimensionForcingIndexFlagTestData(): array
|
|
{
|
|
return [
|
|
[false],
|
|
[true],
|
|
];
|
|
}
|
|
}
|